fix(extensions): restore UI extension targets on add + deploy (DEVX-541)#107
Open
smukherjee-godaddy wants to merge 3 commits into
Open
fix(extensions): restore UI extension targets on add + deploy (DEVX-541)#107smukherjee-godaddy wants to merge 3 commits into
smukherjee-godaddy wants to merge 3 commits into
Conversation
`application add extension embed/checkout` had no --target flag and wrote targets: [], and deploy uploaded every extension to a target equal to the extension *name* — so configured target surfaces were lost and artifacts landed in the wrong place. Ports the TS target handling. - add extension embed/checkout: add required --target (comma-separated, >=1); parse_targets() trims/splits/drops empties; write the parsed targets to godaddy.toml (was hard-coded empty). - collect_extensions: carry each extension's targets (ExtensionDeploy struct) instead of dropping them. - deploy_extension: bundle once, then upload once per resolved target — resolve_upload_targets() maps blocks -> "blocks", embed/checkout -> each configured target (or a single untargeted upload when none). The upload target is the configured value, not the extension name. - tests: parse_targets + resolve_upload_targets. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…on-targets # Conflicts: # rust/src/application/commands/mod.rs
jpage-godaddy
approved these changes
Jul 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Restores end-to-end handling of UI extension “targets” so that extension configuration (godaddy.toml) is preserved through collection and used correctly during deploy uploads, preventing artifacts from being uploaded to incorrect target surfaces.
Changes:
- Adds a required
--targetflag forapplication add extension embed|checkoutand persists parsed targets intogodaddy.toml. - Updates extension collection to retain targets via a new
ExtensionDeploystruct. - Updates deploy logic to upload once per resolved target (including a fixed
blockstarget and an untargeted upload when no targets exist) and adds unit tests for target parsing/resolution.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Preserve stable upload completion events and reuse shared bundle bytes across multi-target uploads.
Collaborator
|
Looks like there are some merge conflicts; can you resolve, and then we should be able to merge. I'll also request another round of Copilot reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
UI extension targets were lost end to end:
application add extension embed/checkouthad no--targetflag and wrotetargets: []togodaddy.toml.collect_extensions()dropped targets entirely.deploy_extension()uploaded every extension withtarget = <extension name>instead of the configured target surface.So embed/checkout artifacts were uploaded to the wrong target locations, and there was no way to specify where an extension should render.
Fix
Ports the TS target handling:
add extension embed/checkout— add a required--target(comma-separated, at least one).parse_targets()trims, splits, and drops empty entries; the parsed targets are written togodaddy.toml(previously hard-coded empty).blocksis unchanged (it takes no target).collect_extensions()— carry each extension's targets via a smallExtensionDeploystruct instead of discarding them.deploy_extension()— bundle once, then upload once per resolved target.resolve_upload_targets()maps:blocks→ the fixed"blocks"target,embed/checkout→ each configured target, or a single untargeted upload (None) when none are configured.The upload's
targetis now the configured value, not the extension name.Impact
--target) → release maps targets (DEVX-540) → deploy uploads per target.Testing
parse_targets(trim/split/drop-empty) andresolve_upload_targets(blocks / no-target / multi-target).cargo test/cargo clippy --all-targets -- -D warnings/cargo fmt --check— all clean.Context
Track A ("ship an app"). Pairs with DEVX-540 (release input maps these targets) and DEVX-539 (deploy activation).